Updated testIds in RN StoryListView to use kind #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
bug
react-native
patch:yes
Hypnosphi
reviewed
Mar 2, 2018
| @@ -14,12 +14,12 @@ SectionHeader.propTypes = { | |||
| selected: PropTypes.bool.isRequired, | |||
| }; | |||
|
|
|||
| const ListItem = ({ title, selected, onPress }) => ( | |||
| const ListItem = ({ kind, title, selected, onPress }) => ( | |||
There was a problem hiding this comment.
Please add a propType for this to make eslint happy =)
There was a problem hiding this comment.
@Hypnosphi, thanks edited the file through github and missed the propTypes below.
Hypnosphi
approved these changes
Mar 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #3129 +/- ##
=========================================
+ Coverage 36.08% 36.1% +0.01%
=========================================
Files 438 438
Lines 9447 9443 -4
Branches 911 886 -25
=========================================
Hits 3409 3409
- Misses 5451 5464 +13
+ Partials 587 570 -17
Continue to review full report at Codecov.
|
Hypnosphi
added
patch:done
Hypnosphi
added a commit
that referenced
this pull request
Mar 6, 2018
Updated testIds in RN StoryListView to use kind
Hypnosphi
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've been working on integrating Detox with storybook. Everything looks really promising because of included StoryListView in RN storybook. The only issue with it is that it doesn't scope stories by the kind. So if you have to stories with same name i.e.
Default statethey will both have same testIDs and it will be difficult to understand which story to click.Issue: Not Scoped testIDS in StoryListView.
What I did
Added kind to testID.
How to test
N/A (no tests here)
Is this testable with jest or storyshots?
Could be.
Does this need a new example in the kitchen sink apps?
No.
Does this need an update to the documentation?
No.